Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Fix controller setup for guests #36904

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix(files): Fix controller setup for guests #36904

merged 1 commit into from
Mar 6, 2023

Conversation

nickvergessen
Copy link
Member

Log

cat /var/www/data/nextcloud.log | grep "TagService::__construct" | wc -l
296

{
  "reqId": "DvqdkPlTS0BENDuqRSIi",
  "level": 3,
  "time": "2023-02-28T14:24:35+00:00",
  "remoteAddr": "…",
  "user": "--",
  "app": "index",
  "method": "GET",
  "url": "/apps/files/api/v1/stats",
  "message": "OCA\\Files\\Service\\TagService::__construct(): Argument #3 ($tagger) must be of type OCP\\ITags, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/AppInfo/Application.php on line 109",
  "userAgent": "…",
  "version": "26.0.0.7",
  "exception": {
    "Exception": "TypeError",
    "Message": "OCA\\Files\\Service\\TagService::__construct(): Argument #3 ($tagger) must be of type OCP\\ITags, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/AppInfo/Application.php on line 109",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/AppInfo/Application.php",
        "line": 109,
        "function": "__construct",
        "class": "OCA\\Files\\Service\\TagService",
        "type": "->",
        "args": [
          [
            "OC\\User\\Session"
          ],
          [
            "OC\\Activity\\Manager"
          ],
          null,
          null,
          [
            "OC\\EventDispatcher\\SymfonyAdapter"
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 171,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 122,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 138,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 487,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 465,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 65,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/AppInfo/Application.php",
        "line": 88,
        "function": "get",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 171,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 122,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 138,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 487,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 465,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 65,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/App.php",
        "line": 148,
        "function": "get",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/Route/Router.php",
        "line": 315,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::",
        "args": [
          "APIController",
          "getStorageStats",
          "*** sensitive parameters replaced ***",
          [
            "files.API.getStorageStats"
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/base.php",
        "line": 1050,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->",
        "args": [
          "/apps/files/api/v1/stats"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/index.php",
        "line": 36,
        "function": "handleRequest",
        "class": "OC",
        "type": "::",
        "args": []
      }
    ],
    "File": "/var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/Service/TagService.php",
    "Line": 59,
    "CustomMessage": "--"
  }
}

Checklist

@nickvergessen
fix(files): Fix controller setup for guests
c02080f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Feb 28, 2023
@nickvergessen nickvergessen requested a review from a team February 28, 2023 14:39
@nickvergessen nickvergessen self-assigned this Feb 28, 2023
@nickvergessen nickvergessen requested review from ArtificialOwl, icewind1991, blizzz, vitormattos and juliusknorr and removed request for a team February 28, 2023 14:39
@nickvergessen nickvergessen merged commit 394ad98 into master Mar 6, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/fix-controller-setup-for-guests branch March 6, 2023 13:20
@nickvergessen
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 6, 2023
Merged
@solracsf
Copy link
Member

@nickvergessen any objection to backporting to 25?

@nickvergessen
Copy link
Member Author

Not there yet. Let's see after #37826

@solracsf
Copy link
Member

Ok, this was mainly because of #3376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@vitormattos vitormattos vitormattos approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: files feature: tags
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @solracsf @vitormattos @juliusknorr